-
Notifications
You must be signed in to change notification settings - Fork 728
Remove /util/docker folder from v3.3/dev branch (now in dedicated repo) #1667
Remove /util/docker folder from v3.3/dev branch (now in dedicated repo) #1667
Conversation
PR #1684 has just been merged. We should now be safe to remove the |
Not sure the removal is really, really permanent. Let's hold this back a bit more until we are really sure. (Yes, I know this is all dragging along. Sorry about that.) |
Yes please. I'm porting this to GHA, so wait a little bit longer. |
Not sure if we all have the same understanding: The code from Removing files here would just be a cleanup measure, and to reduce potential confusion. We'll integrate more and advance more with those two repositories in the weeks to come. |
I saw and understood that. For me the problem right now is that we need to be in sync because we used to have a docker that tested properly, but was constructed using a local Dockerfile. Now moving it away, we need to be sure that our objectives keep being the same (I know it is the CRS support 😄 ), but just to be aware of that. If we want to remove it, I'm not oppossing to. |
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
fix(migration): post migration tasks
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
feat(ci): adds github actions testing
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
fix(ci): change test name and fix default params
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
fix(ci): run tests also on PRs
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
fix(docs): update badges and links in readme
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Prevent bypass of rule 921130
Fix filename reference
Cache-Control: a strict whitelist of possible values
Fix spelling in 3.3.0 changelog
fix: change msg values to not span multiple lines
fix typos found by fossies codespell
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
…rectives Handle multiple directives in 920510
feat(badge): add apache license badge
Fix GHA badges
Drop unneeded tags
Executing linting on every commit makes more sense, and then regression only on tests or rules changed only Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
feat(lint): split actions in linting and regression
Removes the entire
util/docker
folder, which has been migrated to a dedicated repository.See https://github.com/CRS-support/modsecurity-crs-docker
This PR should be merged after the CRS test suite has been refactored to use the owasp/modsecurity-crs image from Docker Hub, and passes obviously.
Relates to: