change module to github.com/SpiderOak/webwormhole #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
reviewed
Jul 12, 2021
| webrtc "github.com/pion/webrtc/v3" | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/client_golang/prometheus/promhttp" | ||
| "golang.org/x/crypto/acme/autocert" | ||
| "nhooyr.io/websocket" | ||
| "webwormhole.io/wormhole" |
There was a problem hiding this comment.
Why don't we use the replace keyword on the flow repo instead? https://stackoverflow.com/questions/14323872/using-forked-package-import-in-go
There was a problem hiding this comment.
I meant to add the replace on the flow repo, not in this one. But am not sure exactly what's needed here.
What we need in FLOW-1966 is to run the docker image that can be built by this fork in tr. As discussed in the meetings, If we need to use git submodules then I believe that's a-ok too.
bdzim
force-pushed
the
feature/FLOW-1966-wormhole-docker-image
branch
from
7cd3904 to
8710bdf
Compare
bdzim
force-pushed
the
feature/FLOW-1966-wormhole-docker-image
branch
2 times, most recently
from
70a9c48 to
b0ebc05
Compare
bdzim
force-pushed
the
feature/FLOW-1966-wormhole-docker-image
branch
from
02452ab to
2541c8a
Compare
…SpiderOak/webwormhole into feature/FLOW-1966-wormhole-docker-image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.