Doc generation and benchmark modules #4151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…keinterface into big_clean_in_components # Conflicts: # src/spikeinterface/sortingcomponents/waveforms/temporal_pca.py
…es_from_teamples()
Harmonization with matching and signatures
Harmonization and cleaning
…keinterface into doc_generation_benchmark
zm711
reviewed
Oct 3, 2025
You are my heroe Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
Merci Zach. C'est super sympa. Ne passe pas trop de temps dessus, tu dois te reposer le week-end!! |
for more information, see https://pre-commit.ci
|
Haha. Oui mais j'adore faire le code. :) |
samuelgarcia
commented
Oct 6, 2025
Co-authored-by: Zach McKenzie <92116279+zm711@users.noreply.github.com>
alejoe91
requested changes
Oct 7, 2025
There was a problem hiding this comment.
Good job camarades!!! @samuelgarcia @yger
Left a bunch of comments, mainly style and grammar :)
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
for more information, see https://pre-commit.ci
|
This is ready for merging (with a squash!) |
…into doc_generation_benchmark
Closed
alejoe91
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge on my side.
Maybe some people with decent english would be happy to destroy typos maybe not. (@chrishalcrow @zm711)
@yger : do you want to have a look ?
Need to be squashed!!!