Skip to content

Fix getRateLimit json double casting ints #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

CaseyHillers
Copy link
Collaborator

I noticed this as my dependency finally migrated to null safety. The issue was double casting ints caused a type error.

Fixes flutter/flutter#90475

I added a test with a response from github

@Pacane
Copy link
Contributor

Pacane commented Sep 28, 2021

Thank you!

@Pacane Pacane merged commit 2446c27 into SpinlockLabs:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[github.dart] getRateLimit fails json parsing
2 participants