-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fix workflow #6
Conversation
Diffs should be one offs from running on ubuntu-latest e32c56b |
Do you know why the resulting screenshots are different, yet looking the same to the eye? |
Well known differences across all platforms https://proandroiddev.com/oh-snap-966bd786b7a4 https://www.linkedin.com/pulse/easy-screenshot-testing-droidcon-london-jose-alc%C3%A9rreca-cz0dc |
More canonical link robolectric/robolectric#8457 |
Hum… this mismatch is not such an ideal situation… |
BTW, what's the reason you programmed it to not run when on the default (main) branch? |
I didn't think having it make changes to main was safe. But it's manual, so up to you |
I don't have a good solution then. Options This) Linux is canonical and updated in CI Don't test screenshots in CI, just update locally |
… main/default branch
@yschimke I think I'd be happy with option B, but I don't know where/how to setup that tolerance, and which number to give it. |
Yep, will do. |
70532d7
to
fe8871a
Compare
0.01 or 1% but can be tuned. If you temporarily set it to 0, and run verifyRoborazziDebug, you'll see the diffs. It's mostly antialiasing of curves etc. |
Thank you very much, Yuri! That's a very welcome addition (plus it's fixing the CI 😄) |
Runnable on a fork of the repository such as
https://github.com/yschimke/ComposeOClock/actions/workflows/fix_workflow.yaml
When run on a branch, generates updated screenshots and commits them.
Example https://github.com/yschimke/ComposeOClock/actions/runs/8030224947