This repository has been archived by the owner on Dec 30, 2020. It is now read-only.
Private keys from APN support #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edamov could you please verify the key is correctly loaded with by this PR? |
|
It works! |
|
Thanks. It seems I introduced a new bug (a test failed on that PR). |
added 2 commits
October 18, 2016 12:59
1 similar comment
|
Merged and tagged as Thanks again |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #141
The keys generated by the Apple Push Notification Service are not correctly loaded by the JWKFactory and the EC key converter.
It seems that the problem comes from the way the keys are encoded.
As per the ASN.1 parser, the sequence that holds the information is wrapped into another sequence. This sequence comes from the RFC5208.
At the moment, this PR fixes the bug. A test has been added.
However the key converter should be updated to be fully compliant with the RFC5915 and RFC5208.