Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to support per-player view distance #1682

Open
phyne opened this issue Nov 6, 2017 · 5 comments
Open

Request to support per-player view distance #1682

phyne opened this issue Nov 6, 2017 · 5 comments
Labels
api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) status: pr pending system: world

Comments

@phyne
Copy link

phyne commented Nov 6, 2017

Referencing this sponge thread

Would it be possible to support per-player view distance? A method to send a certain amount of chunks based on a player's individual setting (either specified by them or the server) would be unbelievable. I stumbled upon paperspigot, and apparently they support this feature.

In any case, thanks for the great work you guys do on Sponge!

@ryantheleach
Copy link
Contributor

Would this prevent the chunks from even loading? or is this just a move to save on serialization / sending to the player?

@parlough
Copy link
Contributor

parlough commented Nov 7, 2017

@parlough
Copy link
Contributor

@dags- I saw you were working on a plugin like this. If you wanted to make PRs to Sponge or at least provide some feedback on how you'd like to see this done in the API that would be fantastic!

@ryantheleach
Copy link
Contributor

#1659 has merged per world view distances FYI.

@dags-
Copy link

dags- commented Dec 13, 2017

World and Player both have methods 'getViewDistance' which refer to different things:

To me, 'get/setChunkRadius' (or similar) makes sense for the server-side notion of chunks around a player (the server setting doesn't change the client's view-distance setting), but even in the server.properties file it's called 'view-distance'.
Alternatively the method currently in Player could just be renamed to something like 'getClientViewDistance' or 'getRenderDistance'?

I'm a little out of touch with the latest Sponge developments in all honestly so not sure what the preferred plan of attack would be.

Other than getter/setters, a reset method as added to the per-World PR would be a good idea.

@ImMorpheus ImMorpheus added api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) status: pr pending labels Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) status: pr pending system: world
Projects
None yet
Development

No branches or pull requests

6 participants