view distance #1659
Merged
view distance #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deamon5550
suggested changes
Oct 4, 2017
| @@ -447,4 +446,20 @@ default void setSerializationBehavior(SerializationBehavior behavior) { | |||
| * @throws IOException If the save failed | |||
| */ | |||
| boolean save() throws IOException; | |||
|
|
|||
| /** | |||
| * Gets the view distance for this world. | |||
There was a problem hiding this comment.
We should specify that the value is in chunks
Deamon5550
reviewed
Oct 4, 2017
| * | ||
| * @param viewDistance The view distance | ||
| */ | ||
| void setViewDistance(final int viewDistance); |
There was a problem hiding this comment.
Also we have no way of unsetting a world's view distance (setting it to use the global setting rather).
There was a problem hiding this comment.
as per SpongePowered/Sponge#1557 (diff) sending a value of -1 resets it.
if this remains in the API, it needs to be documented.
There was a problem hiding this comment.
we can probably do better than that
|
This needs to be updated to address @Deamon5550 's concerns above. |
gabizou
added a commit
that referenced
this pull request
Dec 13, 2017
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
adds #1658