view distance #1557
Merged
view distance #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deamon5550
approved these changes
Oct 4, 2017
JBYoshi
reviewed
Oct 4, 2017
| @@ -103,6 +103,15 @@ | |||
|
|
|||
| @Setting(value = "weather-ice-and-snow", comment = "Enable to allow the natural formation of ice and snow in supported biomes.") | |||
| private boolean weatherIceAndSnow = true; | |||
|
|
|||
| public static final int USE_SERVER_VIEW_DISTANCE = -1; | |||
There was a problem hiding this comment.
Should this be exposed in the API?
There was a problem hiding this comment.
Would a clearCustomViewDistance() method make sense instead?
parlough
approved these changes
Oct 12, 2017
|
|
||
| public void setViewDistance(final int viewDistance) { | ||
| this.viewDistance = viewDistance; | ||
| } | ||
| } |
There was a problem hiding this comment.
New line while you're at it?
gabizou
added a commit
that referenced
this pull request
Dec 13, 2017
Signed-off-by: Gabriel Harris-Rouquette <gabizou@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon