Command API tweaks #2159
Merged
Command API tweaks #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
added
system: command
api: 8 (u)
ST-DDT
reviewed
Jul 6, 2020
| @@ -168,7 +224,7 @@ public static TextBuilder textBuilder() { | |||
| * without such a prefix | |||
| * @return This builder, for chaining. | |||
| */ | |||
| CatalogedTypeBuilder<T> prefix(String prefix); | |||
| CatalogedTypeBuilder<T> defaultNamespace(String prefix); | |||
There was a problem hiding this comment.
I would go for tryNamespace/tryDefaultNamespace or something similar because you can have multiple. defaultNamespace sounds like you can only define one.
dualspiral
force-pushed
the
api8/commands-tweaks
branch
6 times, most recently
from
60e8d26 to
768ba36
Compare
This uses a modified form of the NBT parser to determine the JSON string. Need to ensure parameters can mark themselves as JSON parsers.
…tion hints to the client
dualspiral
force-pushed
the
api8/commands-tweaks
branch
from
969f603 to
5213414
Compare
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks for commands, from as I implement and realise I did things wrong (or can add super simple things).