Rename ClientCompletionKey and ClientSuggestionProvider #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
added
system: command
api: 8 (u)
dualspiral
force-pushed
the
api8/rename-cck
branch
from
494288f to
51a040f
Compare
dualspiral
force-pushed
the
api8/rename-cck
branch
2 times, most recently
from
bd36e36 to
999dc34
Compare
Specifically: * ClientCompletionKey -> CommandTreeNodeType * ClientSuggestionProvider -> CommandCompletionProvider The previous terminology was a hangover to when I originally designed the system and from numerous issues and chats on Discord, it's clear that... well, it's not clear what they are. Along with making sure we're consistent with using "completion" instead of "suggestion", it makes sense to revisit this and make sure the names are sensible (and the Javadocs are clearer) I have not renamed "ClientCompletionType" because that's for use with parameterized commands and for what it does, it's a reasonable name (while I'm open to that being renamed, it's less important here)
dualspiral
force-pushed
the
api8/rename-cck
branch
from
999dc34 to
376460a
Compare
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
Specifically:
The previous terminology was a hangover to when I originally designed the system and from numerous issues and chats on Discord, it's clear that... well, it's not clear what they are. Along with making sure we're consistent with using "completion" instead of "suggestion", it makes sense to revisit this and make sure the names are sensible (and the Javadocs are clearer)
I have not renamed "ClientCompletionType" because that's for use with parameterized commands and for what it does, it's a reasonable name (while I'm open to that being renamed, it's less important here).
This kind of follows on from #2347 where we should basically be consistent with terminology, but done separately as the CCK rename is out of scope there.
This PR won't stick around for long, mostly a diff check and a quick oppotunity for any other reasonable comments.