Adjustments to Chunk and World interfaces #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
commented
Jul 21, 2021
src/main/java/org/spongepowered/api/event/world/chunk/WorldChunkEvent.java
Outdated
Show resolved
Hide resolved
gabizou
reviewed
Jul 22, 2021
src/main/java/org/spongepowered/api/event/world/chunk/WorldChunkEvent.java
Outdated
Show resolved
Hide resolved
gabizou
reviewed
Jul 22, 2021
src/main/java/org/spongepowered/api/world/generation/GenerationRegion.java
Outdated
Show resolved
Hide resolved
gabizou
reviewed
Jul 22, 2021
src/main/java/org/spongepowered/api/world/generation/GenerationRegion.java
Show resolved
Hide resolved
dualspiral
added
api: 8 (u)
dualspiral
force-pushed
the
api8/missing-level-chunk
branch
2 times, most recently
from
6216cd7 to
320ff4a
Compare
There have been multiple renames to more accurately reflect what the objects represent. Particularly of note: * ProtoWorld is now WorldLike * Chunk is now WorldChunk * ProtoChunk is now Chunk (as it is the basic chunk) * PrimitiveChunk is now a GenerationChunk * ChunkVolume no longer implements BlockVolume, just Volume * Volume methods that return block co-ordinates are renamed to not include the word "block" to reduce confusion, as they return positions, not blocks * ChunkEvent has a WorldScoped subinterface that most chunk events now implement. * regenerateChunk has been moved from ServerLevel to ChunkManager and now returns a completable future.
dualspiral
force-pushed
the
api8/missing-level-chunk
branch
from
41298bf to
f8f8e28
Compare
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | Sponge
Been discussed in Discord - sorting out confusing naming and such.