Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the plugin optional for CommandMapping #2396

Merged
merged 1 commit into from
Oct 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.spongepowered.api.command.registrar.CommandRegistrar;
import org.spongepowered.plugin.PluginContainer;

import java.util.Optional;
import java.util.Set;

/**
Expand Down Expand Up @@ -59,11 +60,11 @@ public interface CommandMapping {
Set<String> allAliases();

/**
* Gets the plugin that owns the command.
* Gets the plugin that owns the command, if known.
*
* @return The plugin.
*/
PluginContainer plugin();
Optional<PluginContainer> plugin();

/**
* Gets the {@link CommandRegistrar} that registered this command.
Expand Down