Make ItemStack also implement HoverEventSource #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
added
system: text
api: 8 (u)
dualspiral
approved these changes
Feb 13, 2022
gabizou
reviewed
Feb 14, 2022
| @@ -57,7 +59,7 @@ | |||
| * use {@link ValueContainer#get(Key)} in order to retrieve information regarding | |||
| * this item stack.</p> | |||
| */ | |||
| public interface ItemStack extends SerializableDataHolder.Mutable, ComponentLike { | |||
| public interface ItemStack extends SerializableDataHolder.Mutable, ComponentLike, HoverEventSource<HoverEvent.ShowItem> { | |||
There was a problem hiding this comment.
Not that I'm expecting people to be implementing an ItemStack, but is there a way to default implement the method itself being added?
There was a problem hiding this comment.
Not in any complete manner -- the hover event includes SNBT-serialized data from the stack's tag, which we don't reeealy expose in API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API | Impl
This matches
ItemStackSnapshot