Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make concurrency less brittle #39

Closed
zml2008 opened this issue Jul 27, 2021 · 0 comments · Fixed by #45
Closed

Make concurrency less brittle #39

zml2008 opened this issue Jul 27, 2021 · 0 comments · Fixed by #45

Comments

@zml2008
Copy link
Member

zml2008 commented Jul 27, 2021

Currently, due to Gradle restrictions some operations have to be completed on Gradle-owned threads, including any configuration resolution or execution of workers. This leads to some awkward and brittle arrangements to ensure configurations are resolved at the right points, most visible in DecompileJarTask and the infrastructure around produceAssociatedArtifactSync.

Instead, I'd like to see a way to have an Executor that can run on a Gradle thread, using a SynchronousQueue to pass tasks back to the Gradle thread, or something along those lines. This will let VG stay fully in CompletableFuture land for its operations, and more elegantly synchronize only when actually necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant