Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Specify snapshot repo as plugin repository in Jenkins build script #1

Merged
merged 7 commits into from
Feb 11, 2021
Merged

chore: Specify snapshot repo as plugin repository in Jenkins build script #1

merged 7 commits into from
Feb 11, 2021

Conversation

slarse
Copy link
Contributor

@slarse slarse commented Feb 10, 2021

This PR does two things:

  1. Updates the snapshot repository to the new OW2 Nexus repo
  2. Specifies this repository in <pluginRepositories> instead of <repositories>. This causes Maven to use this repository when searching for dependencies of plugins.

This doesn't solve the infernal logger problem, but at least it causes the build script to pull down the snapshot version of Spoon instead of the latest beta (see INRIA/spoon#3775 for details). You can see from this build in which I pointed it to this exact script version, that it actually now pulls down 8.4.0-SNAPSHOT: https://ci.inria.fr/sos/job/Jimfs/1551/console (toward the bottom)

As opposed to e.g. this build, where 8.4.0-beta-13 is pulled: https://ci.inria.fr/sos/job/Commons-codec/1990/console

So, this is at least one step closer to correct behavior on Jenkins. A small step.

@monperrus
Copy link
Contributor

In theory this repo is generated so we don't take PR.

But: it's not yet generated, see INRIA/spoon#3759

And, we do need to see if this contributes to fixing the problem.

So merging!

@monperrus monperrus merged commit f00a3a9 into SpoonLabs:main Feb 11, 2021
@monperrus
Copy link
Contributor

And, we do need to see if this contributes to fixing the problem.

if it does, we'll make the same PR on the original file on the main Spoon repo

@slarse slarse deleted the specify-snapshot-repo-as-plugin-repository branch February 11, 2021 09:05
@slarse
Copy link
Contributor Author

slarse commented Feb 11, 2021

Ohh, right, I probably meant to make this PR to spoon. I'm putting my hands in so many repos right now that I'm starting to mix them up.

But yes, this alteration to the build script fixes the problem that we weren't pulling the latest snapshot. See e.g. this build: https://ci.inria.fr/sos/job/Jimfs/1553/console

At the top you can see that the build script is pulled from the canonical URL, and toward the bottom you can see that it uses the latest Spoon snapshot. We still get the build failure due to something with the logging madness. As suggested in INRIA/spoon#3775, could you try emptying any and all Maven caches (~/.m2 directories) on the Jenkins nodes? As I can't reproduce the problem on any of my local machines, I can't think of anything else than that a jar-file has become corrupted.

@monperrus
Copy link
Contributor

could you try emptying any and all Maven caches (~/.m2 directories) on the Jenkins nodes

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants