set up declarative releases for Spoon #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
reviewed
Apr 1, 2022
| @@ -0,0 +1,6 @@ | |||
| [ | |||
There was a problem hiding this comment.
Why is this an array? For each release, we can just update two attributes, commit_sha and version. Once it is updated, that PR can be merged. There is no harm in keeping an array, except the script has some negligible extra work of picking up the first element.
|
This array is meant to be append-only: we append the new release information. |
This was referenced Apr 4, 2022
|
FYI, manually published 17e000b58363dee4ee1687e582f13ef993b387e0 as 10.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem being solved:
Solution: have a declarative specification of releases.
Next a script to be written will take this data as input and push to Maven Central appropriately.