Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/comment #47

Merged
merged 13 commits into from
Jan 14, 2024
Merged

Feature/comment #47

merged 13 commits into from
Jan 14, 2024

Conversation

jinyr1128
Copy link
Contributor

@jinyr1128 jinyr1128 commented Jan 12, 2024 •
edited
Loading

개요

테스트 작성

작업사항

커멘트 테스트 코드 작성

변경로직

생성 조회 변경 삭제 테스트

관련이슈

comment 통합테스트(#49)

zzzzseong
zzzzseong approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@zzzzseong zzzzseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

단위테스트와 통합테스트 코드를 모두 작성하신 유록님은 코딩의 신인가요??

src/main/java/com/sportsecho/comment/dto/CommentRequestDto.java Outdated

@Getter
@NoArgsConstructor
@Data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa??? @DaTa???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안그러면 안되는걸.......요?ㅋㅋㅋㅋㅋㅋ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bulider를 사용합시다 어떠신지요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@builder로 바꾸겠습니다...

@jinyr1128 jinyr1128 linked an issue Jan 12, 2024 that may be closed by this pull request
comment 통합테스트 #49
Closed
@jinyr1128 jinyr1128 self-assigned this Jan 12, 2024
@jinyr1128 jinyr1128 added the feature new feature label Jan 12, 2024
zomeong
zomeong approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@zomeong zomeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴니다

@jinyr1128 jinyr1128 merged commit 3e07eb4 into dev1 Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomeong zomeong zomeong approved these changes

@zzzzseong zzzzseong zzzzseong approved these changes

Assignees

@jinyr1128 jinyr1128

Labels
feature new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

comment 통합테스트
3 participants
@jinyr1128 @zzzzseong @zomeong