added validations / auto-complete for lyrics_stat param #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add the last 2 themes |
done 👍🏻 |
|
I had to restore the code to its original state because in some cases running the script was producing an error You can reproduce the error by looking at this issue. |
|
Strange, seems like there's an issue when invoke-expression tries to execute the code without the default parameter, but when manually invoking it from the command line, it works. I think its got something to do with invoke-expression handling the parameters. I might have to look more into it. but I could suggest another change where autocomplete can be added without the validations though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation list taken from: #50 (comment)
Helps when invoking install.ps1 manually: