Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPRIS dbus command play_pause only plays, does not pause #1018

Closed
DhruvaSambrani opened this issue Nov 14, 2021 · 14 comments
Closed

MPRIS dbus command play_pause only plays, does not pause #1018

DhruvaSambrani opened this issue Nov 14, 2021 · 14 comments
Labels
bug A functionality or parts of a program that do not work as intended

Comments

@DhruvaSambrani
Copy link

Description
MPRIS dbus command play_pause only plays, does not pause a playing song.

To Reproduce

  1. Install playerctl
  2. playerctl -p spotifyd play_pause
  3. Song plays
  4. playerctl -p spotifyd play_pause
  5. Song continues playing

Expected behavior

Song stops playing

Compilation flags

  • AUR Build

Versions (please complete the following information):

  • OS: Linux 5.10.70-1-MANJARO GNU/Linux
  • Spotifyd: 0.3.2
  • cargo: AUR Build, not used. 1.55.0

Additional context
spotifyd run via systemd
When spotify run without systemd, it does not react to any MPRIS commands

@DhruvaSambrani DhruvaSambrani added the bug A functionality or parts of a program that do not work as intended label Nov 14, 2021
@NikitaIvanovV
Copy link

The same problem! However, I noticed that playerctl pause and playerctl play work correctly.

@pietryszak
Copy link

playerctl --player spotifyd play
playerctl --player spotifyd pause workig fine
playerctl play-pause not working for me.

@Diaoul
Copy link

Diaoul commented Dec 7, 2021

I have the same issue. Let me know if there is anything I can do to help fix this.
Maybe an issue upstream with librespot as the code seems to correctly forward the instruction to the lib. I am no Rust dev so my little investigating led me here but no luck.
I can confirm it works from pause to play but not the other way around.

@Diaoul
Copy link

Diaoul commented Dec 7, 2021

Actually, this may be already fixed upstream: librespot-org/librespot@392a12a

Edit: Probably fixed with #977

@pietryszak
Copy link

Actually, this may be already fixed upstream: librespot-org/librespot@392a12a

Edit: Probably fixed with #977

It's merged to spotifyd 17 minutes ago, so we need to test it.

@NikitaIvanovV
Copy link

Just tested, doesn't seem to work :(

@Diaoul
Copy link

Diaoul commented Dec 7, 2021

Indeed, but I don't even see the option use-mpris from the --help anymore and playerctl -l does not show spotifyd so I think it is not even started for some reason.

@Diaoul
Copy link

Diaoul commented Dec 7, 2021

Nevermind I war missing the feature flags to properly build with mpris support... Sorry for the noise. I just tested with the prebuilt binary instead as I have no idea how to activate the feature flags and the wiki is missing instructions on that.

It works fine for me! 🎉
What binary did you test this with @NikitaIvanovV ?

@NikitaIvanovV
Copy link

NikitaIvanovV commented Dec 7, 2021

@Diaoul A binary from AUR package spotifyd-full-git right after d10216a was commited.

@Diaoul
Copy link

Diaoul commented Dec 8, 2021

I used the prebuilt binary from the latest release on GitHub 🤷‍♂️

@NikitaIvanovV
Copy link

NikitaIvanovV commented Dec 8, 2021

I tried using the prebuilt binary and it worked!

@Diaoul
Copy link

Diaoul commented Dec 9, 2021

For those on Arch, the version with the fix is available as regular package and it works. This issue can be closed.

@pietryszak
Copy link

I use fedora copr spotifyd with the newest version spotifyd 0.3.3, and it's working fine.
This issue can be closed.

@DhruvaSambrani
Copy link
Author

The uldated version works well. I am closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A functionality or parts of a program that do not work as intended
Projects
None yet
Development

No branches or pull requests

4 participants