feat: option for audio format #1082
Conversation
There was a problem hiding this comment.
Looks good and works for me:
$ target/debug/spotifyd --no-daemon --audio-format "S32"
Loading config from "/home/user/.config/spotifyd/spotifyd.conf"
No password specified. Checking password_cmd
No password_cmd specified
No proxy specified
Using software volume controller.
Connecting to AP "ap.spotify.com:443"
Authenticated as "user" !
Using Alsa sink with format: S32
Country: "DE"
...Now we'll just have to wait for maintainers to come around and review this.
There was a problem hiding this comment.
Just two additional nitpicks. Looking over config.rs I have some additional improvements in mind like switching to clap or resurrecting this PR, but those are more general and definitely out-of-scope for this PR.
sapristi
force-pushed
the
master
branch
2 times, most recently
from
9c510cc
to
cf52e80
Compare
|
In the Also not much used to github PR, how the hell is there no comment thread ? Or am I missing something ? |
|
@sapristi With the recent PRs that have been merged, this PR now has merge conflicts. If you could resolve them, maybe we can get that into the next release? |
slondr
added
the
waiting for feedback
eladyn
force-pushed
the
master
branch
2 times, most recently
from
fc84cfd
to
62bee6d
Compare
|
I took the liberty to take this PR and rebase it on the current master. So this could potentially also go into the next release. |
slondr
added
enhancement
Add support for audio-format configuration.
Closes #1081