improve error reporting #1108
Merged
improve error reporting #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladyn
force-pushed
the
improve_error_reporting
branch
from
d5588d8 to
e555ef6
Compare
robinvd
approved these changes
Sep 26, 2022
SimonTeixidor
approved these changes
Sep 26, 2022
|
Looks good to me! |
|
Thanks to both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1107
@chinchilla-manaka, it would be great, if you'd be able to test this version on a system without
syslog-nginstalled and see if it improves the situation.In addition to that, this builds upon #789 and improves the error reporting in main overall. By relying on the panic hook from
eyre/color_eyreinstead of using our own, we get more beautiful and clearer panic messages that are also easier to debug.Example:
