refactor: report name of selem that cannot be found #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is now green for the newly added code but failing due to a new lint that is added to clippy. This also affects the master branch so I split this off to a separate PR: #438 |
|
Wow, thanks! I'll try to spare some time off later on in the evening and merge all PRs that are easy to do. Thanks again for your contribution! |
|
Thanks! This should hopefully turn green once #438 is in and merged here. |
mainrs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user's volume control is not correctly configured the following (unhelpful) warning is logged:
It does not say which selem cannot be found. Let's output this information to help users debug their configuration files.
In my case this PR helped me discover that it was using
PCMas the name of the selem instead ofalsa. This led me to #283 which solved my problem.