Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki2docs #783

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Wiki2docs #783

merged 4 commits into from
Jan 21, 2021

Conversation

vringar
Copy link
Contributor

@vringar vringar commented Jan 18, 2021

Closes #635

@JojiiOfficial
Copy link
Member

Nice Work! Could you squash it into one commit?

@vringar
Copy link
Contributor Author

vringar commented Jan 18, 2021

This is PR is currently mostly copying stuff from either the wiki or the README. There should probably more interlinking and a better introduction.

@vringar
Copy link
Contributor Author

vringar commented Jan 18, 2021

Nice Work! Could you squash it into one commit?

Sure :) Any guidelines to the format of the commit message I should be aware of?

@JojiiOfficial
Copy link
Member

No. I just think its more clean being one commit :)

Introduced mdbooks
Added action to push mdbook to hg-pages
@vringar
Copy link
Contributor Author

vringar commented Jan 18, 2021

Done!

@JojiiOfficial JojiiOfficial requested a review from a team January 18, 2021 19:09
JojiiOfficial
JojiiOfficial previously approved these changes Jan 18, 2021
@robinvd
Copy link
Contributor

robinvd commented Jan 18, 2021

Will look at it tomorrow, a bit too big to quickly check.

@robinvd
Copy link
Contributor

robinvd commented Jan 21, 2021

looks good! two things:

  • did you test the CI?
  • i think @sirwindfield was interested in this, so maybe wait a bit if he wants to review or merge after maybe a week if he doenst respond?

@vringar
Copy link
Contributor Author

vringar commented Jan 21, 2021

looks good! two things:

  • did you test the CI?

No, because I don't know how. However I just yoinked it directly from here so I'm hoping it works.

  • i think @sirwindfield was interested in this, so maybe wait a bit if he wants to review or merge after maybe a week if he doenst respond?

Seems good to me :)

.github/workflows/docs.yml Outdated Show resolved Hide resolved
docs/book.toml Outdated Show resolved Hide resolved
@robinvd robinvd requested a review from mainrs January 21, 2021 10:33
@mainrs
Copy link
Member

mainrs commented Jan 21, 2021

No, because I don't know how. However I just yoinked it directly from here so I'm hoping it works.

Ah, now it makes sense why someone was opening up the issue for the 404 :)


### PortAudio

To use PortAudio (works on macOS), compile with the `--features` flag to enable it:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on linux too. I'm using portaudio and (compiled with the right rust version) It works! Mabe we should remove the 'works on MacOS' part?

@robinvd robinvd merged commit cc86d7a into Spotifyd:master Jan 21, 2021
@robinvd
Copy link
Contributor

robinvd commented Jan 21, 2021

alright, lets see if the CI works :p

@mainrs
Copy link
Member

mainrs commented Jan 21, 2021

works! https://spotifyd.github.io/spotifyd/

@robinvd
Copy link
Contributor

robinvd commented Jan 21, 2021

now checking the README, i dont think there currently is a link to the book

@mainrs
Copy link
Member

mainrs commented Jan 21, 2021

I just added one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move readme content to (well structured) wiki
4 participants