Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add anti-aliasing to the corners of the pop-up window #13

Closed
UltimateTanA opened this issue Nov 16, 2021 · 4 comments
Closed
Labels
✨ enhancement New feature or request

Comments

@UltimateTanA
Copy link

I would like to suggest a very minor improvement that'd give some polish
if you notice the pop-up that comes up, it has corners that are kind of pixelated and not perfectly curved
it seems like i'm nitpicking but i think it's the thing that we all see every now and then and polishing it would make your tool much nicer to use
image

@SpriteOvO
Copy link
Owner

SpriteOvO commented Nov 16, 2021

Yes, it is worth improving. I have tried adding anti-aliasing to the corners before, but it doesn't seem to be as easy as I thought. Don't worry, I'll try again later.

@SpriteOvO SpriteOvO added the ✨ enhancement New feature or request label Nov 16, 2021
@SpriteOvO SpriteOvO changed the title [Feature Request] [Feature Request] Add anti-aliasing to the edges of the pop-up window Nov 16, 2021
@SpriteOvO SpriteOvO changed the title [Feature Request] Add anti-aliasing to the edges of the pop-up window [Feature Request] Add anti-aliasing to the corners of the pop-up window Nov 16, 2021
@SpriteOvO
Copy link
Owner

SpriteOvO commented Nov 16, 2021

Could you try this commit f456810? (You can download the installer of this commit from GitHub CI Artifacts)
It's still a bit pixelated, but for me it's a bit better than before.

The rounded corners implemented through the WA_TranslucentBackground flag would be perfect, but it doesn't work with QVideoWidget or QMediaPlayer, which causes the animation to not play. This is another fairly historical issue (QTBUG-8119) with Qt again, and they don't seem to be planning to fix it :(

@UltimateTanA
Copy link
Author

UltimateTanA commented Nov 24, 2021

Could you try this commit f456810? (You can download the installer of this commit from GitHub CI Artifacts) It's still a bit pixelated, but for me it's a bit better than before.

The rounded corners implemented through the WA_TranslucentBackground flag would be perfect, but it doesn't work with QVideoWidget or QMediaPlayer, which causes the animation to not play. This is another fairly historical issue (QTBUG-8119) with Qt again, and they don't seem to be planning to fix it :(

Um I'm very new to Github and so I don't know how exactly to go about it
(fun fact, i created my account just to add this feature request)
Edit: If you can guide me, i will try it out

Edit 2: ah i figured it out, just had to install the newer version you linked
image
and YES it looks so much better now!

@SpriteOvO
Copy link
Owner

Close since there may not be a better way to improve it further at present.
The implemented improvements will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants