use is-terminal instead of atty dep for RUSTSEC-2021-0145 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(also if this looks good - would love a point release with this included <3) cc @SpriteOvO |
|
@bpowers Thanks for your contributions! Please run |
|
@SpriteOvO thanks! I rebased, and (I think) need you to kickoff the workflow again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rustsec.org/advisories/RUSTSEC-2021-0145 details an alignment/unsoundness issue in
atty, which is solved with the smalleris-terminalcrate. This PR changes the dependency!Tests pass locally - happy to iterate if there are things that could be factored/done better