Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding code of conduct #25 #26

Merged
merged 3 commits into from
Oct 1, 2023
Merged

adding code of conduct #25 #26

merged 3 commits into from
Oct 1, 2023

Conversation

VoidVampire
Copy link
Contributor

@VoidVampire VoidVampire commented Oct 1, 2023 •
edited
Loading

I have added a sufficient code of conduct file as per #25

@VoidVampire VoidVampire changed the title adding code of conduct adding code of conduct #25 Oct 1, 2023
@VoidVampire
Copy link
Contributor Author

I have a request. If my PR is good, can you merge it under hacktoberfest-accepted label, otherwise it won't be counted as far as I know.

Spydr06
Spydr06 requested changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@Spydr06 Spydr06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've stated a few changes necessary to proceed

CODE_OF_CONDUCT.md Outdated

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at
opensource@dagworks.io.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this to something relevant to our project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved other changes. For this particular change, linking your twitter was the best link I could find which could be used in this stance.
My other suggestion is to remove those 3 lines entirely but for now, I have not done that. Please check the new commit.

CODE_OF_CONDUCT.md Outdated
**Community Impact**: Use of inappropriate language or other behavior deemed
unprofessional or unwelcome in the community.

**Consequence**: A private, written warning from community leaders, providing
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project is only on github right now, and unless it gets relevance, it will stay like that. GitHub does not allow private messaging.

CODE_OF_CONDUCT.md Outdated
Comment on lines 96 to 114
### 3. Temporary Ban

**Community Impact**: A serious violation of community standards, including
sustained inappropriate behavior.

**Consequence**: A temporary ban from any sort of interaction or public
communication with the community for a specified period of time. No public or
private interaction with the people involved, including unsolicited interaction
with those enforcing the Code of Conduct, is allowed during this period.
Violating these terms may lead to a permanent ban.

### 4. Permanent Ban

**Community Impact**: Demonstrating a pattern of violation of community
standards, including sustained inappropriate behavior, harassment of an
individual, or aggression toward or disparagement of classes of individuals.

**Consequence**: A permanent ban from any sort of public interaction within
the community.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I to my knowledge, github doesn't have temporary or permanent bans. I have the choice between reporting the user to github and deleting any interactions.

Spydr06
Spydr06 requested changes Oct 1, 2023
View reviewed changes
CODE_OF_CONDUCT.md Outdated
Comment on lines 70 to 78
## Enforcement Guidelines

Community leaders will follow these Community Impact Guidelines in determining
the consequences for any action they deem in violation of this Code of Conduct:

### 1. Correction

**Community Impact**: Use of inappropriate language or other behavior deemed
unprofessional or unwelcome in the community.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho, the guidelines seem pretty important for this, just leave out the "banning/warning" stuff

Spydr06
Spydr06 approved these changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@Spydr06 Spydr06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I might expand on this in the future

@Spydr06 Spydr06 added the hacktoberfest-accepted Accepted PR for the 2023 Hacktoberfest label Oct 1, 2023
@Spydr06 Spydr06 merged commit d6c25b1 into Spydr06:main Oct 1, 2023
toadkarter added a commit to toadkarter/logicrs that referenced this pull request Oct 8, 2023
@toadkarter
parent 3b28ab6
97294ab 
author toadkarter <vrakhmanin1@gmail.com> 1696714738 +0100
committer toadkarter <vrakhmanin1@gmail.com> 1696751330 +0100

parent 3b28ab6
author toadkarter <vrakhmanin1@gmail.com> 1696714738 +0100
committer toadkarter <vrakhmanin1@gmail.com> 1696751324 +0100

# This is the 1st commit message:

Adds serialized settings file that saves theme state.

# This is the commit message Spydr06#2:

#Adding functionality for saving theme to config file.

# This is the commit message Spydr06#3:

#Loading custom theme if a new window has been created.

# This is the commit message Spydr06#4:

#Setting initial radio button state to what is in the settings when loading Theme.

# This is the commit message Spydr06#5:

#Changing settings file to save in the OS specific config directory.

# This is the commit message Spydr06#6:

#Adding Fedora dependencies to Readme.

# This is the commit message Spydr06#7:

#adding code of conduct

# This is the commit message Spydr06#8:

#edit code of conduct

# This is the commit message Spydr06#9:

#edit code of conduct

# This is the commit message Spydr06#10:

#chore: made Rust CI workflow
# This is the commit message Spydr06#11:

#added explanatory comments to rust_ci.yml
# This is the commit message Spydr06#12:

#updated checkout action

# This is the commit message Spydr06#13:

#used official cargo deny action

# This is the commit message Spydr06#14:

#use nightly toolchain

# This is the commit message Spydr06#15:

#Update INSTALL.md
# This is the commit message Spydr06#16:

#Bump version number
# This is the commit message Spydr06#17:

#Bump version number to `0.1.2`
# This is the commit message Spydr06#18:

#new examples

# This is the commit message Spydr06#19:

#Add macos install instructions
# This is the commit message Spydr06#20:

#ci: added libadwaita build steps to get CI jobs working

# This is the commit message Spydr06#21:

#added nsi script

# This is the commit message Spydr06#22:

#changed directories

# This is the commit message Spydr06#23:

#added relative path

# This is the commit message Spydr06#24:

#Delete nsi script directory
# This is the commit message Spydr06#25:

#Implement mux and demux

# This is the commit message Spydr06#26:

#add docs for mux, demux

# This is the commit message Spydr06#27:

#cargo fmt

#fix clippy issues

encoder decoder examples

fix CI issues with `cargo audit` and `cargo deny`

improve rendering of connection being drawn

add d flip flop, d latch, fix t flip flop

Fix examples, add q and !q to flip flops

Add docs for flip flops

run cargo fmt

fix macos shortcuts

Update README.md

cmd+backspace for deletion on mac

Add build instructions for libadwaita

Fixing up imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spydr06 Spydr06 Spydr06 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted PR for the 2023 Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VoidVampire @Spydr06