Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update item slots #1159

Closed
misode opened this issue May 17, 2024 · 0 comments · Fixed by #1179
Closed

Update item slots #1159

misode opened this issue May 17, 2024 · 0 comments · Fixed by #1179
Assignees
@Nico314159
Labels
🐛 bug Something isn't working 👍 good first issue Issues that are easy to work on for new code contributors /java-edition
Milestone
Release 4.0.0

Comments

@misode
Copy link
Member

misode commented May 17, 2024

Some new slots are not available in the current item_slot parser (for example contents or armor.body). Special care should be taken that these new slot values are only available in the new versions by comparing the currently loaded version.

This could be solved together with #1157, but if it isn't; check that the new item slots are also availble for this item_slots parser.
@misode misode added 🐛 bug Something isn't working /java-edition labels May 17, 2024
@misode misode added this to the Release 4.0.0 milestone May 17, 2024
@misode misode added the 👍 good first issue Issues that are easy to work on for new code contributors label May 17, 2024
Nico314159 added a commit to Nico314159/Spyglass that referenced this issue May 19, 2024
@Nico314159
Implement 1.20.5+ item slots
f828e55 
Fixes SpyglassMC#1159
@Nico314159 Nico314159 mentioned this issue May 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nico314159 Nico314159

Labels
🐛 bug Something isn't working 👍 good first issue Issues that are easy to work on for new code contributors /java-edition
Projects
None yet
Milestone
Release 4.0.0
Development

Successfully merging a pull request may close this issue.

Implement 1.20.5+ item slots Nico314159/Spyglass
2 participants
@misode @Nico314159