Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦺 Validate command tree patch #1152

Merged
merged 2 commits into from
May 31, 2024
Merged

🦺 Validate command tree patch #1152

merged 2 commits into from
May 31, 2024

Conversation

SPGoding
Copy link
Member

@SPGoding SPGoding commented May 15, 2024

Resolves #1113.

Prerequisites

Changes

  • Patch minecraft:nbt_compound_tag parsers
  • Patch minecraft:nbt_path parsers
  • Patch minecraft:nbt_tag parsers
  • Patch minecraft:resource_location parsers
  • Patch minecraft:uuid parsers
  • Add necessary permission properties for new commands

@misode
Copy link
Member

misode commented May 16, 2024

Perhaps it would be useful to have some kind of validator that runs in development, checking the merged tree patch and logging warnings for each node that doesn't have the necessary patches?

@SPGoding SPGoding force-pushed the tree-patch-validation branch from bc24add to 69d2a6e Compare May 18, 2024 01:29
This was referenced May 21, 2024
@SPGoding SPGoding changed the title 🐛 Validate command tree patch 🦺 Validate command tree patch May 21, 2024
@SPGoding SPGoding marked this pull request as ready for review May 27, 2024 01:26
@SPGoding SPGoding force-pushed the tree-patch-validation branch from 5672b87 to b7a42b6 Compare May 27, 2024 02:10
* No more magic indices in `dispatchedBy` and
  `indexedBy`
* Add documentation for `isPredicate` and set it to
  `true` for `execute if data`.
* Separate `nbtAccessType` and `vaultAccessType`
  and add access type information to
  `NbtParserProperties`
* Only allow tags for `locatebiome` since 1.18.2
@MulverineX MulverineX requested a review from NeunEinser May 30, 2024 06:02
@misode misode merged commit 176253e into main May 31, 2024
3 checks passed
@misode misode deleted the tree-patch-validation branch May 31, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate all command patches
3 participants