fix(execution): persist Proposal status before CPI

Squads-Protocol · Jul 3, 2023 · c2e81e1 · c2e81e1
1 parent e115a40
commit c2e81e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/programs/multisig/src/instructions/batch_execute_transaction.rs b/programs/multisig/src/instructions/batch_execute_transaction.rs
@@ -149,6 +149,8 @@ impl BatchExecuteTransaction<'_> {
         let current_status = proposal.status.clone();
         // Set the proposal state to Executing to prevent reentrancy attacks (e.g. cancelling proposal) in the middle of execution.
         proposal.status = ProposalStatus::Executing;
+        let proposal_account_info = proposal.to_account_info();
+        proposal.try_serialize(&mut &mut proposal_account_info.data.borrow_mut()[..])?;
 
         // Execute the transaction message instructions one-by-one.
         executable_message.execute_message(

diff --git a/programs/multisig/src/instructions/vault_transaction_execute.rs b/programs/multisig/src/instructions/vault_transaction_execute.rs
@@ -130,6 +130,8 @@ impl VaultTransactionExecute<'_> {
 
         // Set the proposal state to Executing to prevent reentrancy attacks (e.g. cancelling proposal) in the middle of execution.
         proposal.status = ProposalStatus::Executing;
+        let proposal_account_info = proposal.to_account_info();
+        proposal.try_serialize(&mut &mut proposal_account_info.data.borrow_mut()[..])?;
 
         // Execute the transaction message instructions one-by-one.
         executable_message.execute_message(