Skip to content

Cleaning release code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ablattmann merged 11 commits into from
Jun 22, 2023
Merged

Cleaning release code #1

ablattmann merged 11 commits into from
Jun 22, 2023

Conversation

@benjaminaubin
Copy link
Contributor

@benjaminaubin benjaminaubin commented Jun 22, 2023 •
edited
Loading

  • Absolute imports to partial ones
  • Clean readme
  • Add init
  • Sorting imports
  • Black formating
  • Switched ldm -> sgm (Stability Generative Models)

@benjaminaubin benjaminaubin self-assigned this Jun 22, 2023
jenuk
jenuk reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jenuk jenuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read through it

@benjaminaubin benjaminaubin marked this pull request as ready for review June 22, 2023 15:17
@ablattmann
Copy link

ablattmann commented Jun 22, 2023

Hi @benjaminaubin thanks for this! Testing it now :)

@benjaminaubin
Copy link
Contributor Author

benjaminaubin commented Jun 22, 2023

@ablattmann I still have one issue with taming-transformer though. Cannot include it in setup.py ...
So I am planning to create a branch in the taming-transformer repo with proper naming to fix this :D

@ablattmann ablattmann merged commit 8153f92 into main Jun 22, 2023
@ablattmann ablattmann deleted the release_cleaning branch June 22, 2023 16:49
@JPW0080 JPW0080 mentioned this pull request Jul 8, 2023
Open
palp added a commit that referenced this pull request Jul 26, 2023
@palp
Merge pull request #1 from palp/inference
e5a6443 
Refactor helpers
@NicerY NicerY mentioned this pull request Nov 22, 2023
Open
@NeptuneNep NeptuneNep mentioned this pull request Nov 23, 2023
Open
@kaijingxjtu kaijingxjtu mentioned this pull request Nov 24, 2023
Open
@lckj2009 lckj2009 mentioned this pull request Dec 6, 2023
Open
@oXEKo oXEKo mentioned this pull request Feb 24, 2024
Open
@kaikaizhangdragonplus kaikaizhangdragonplus mentioned this pull request Mar 21, 2024
Open
@litter-bird-big-dream litter-bird-big-dream mentioned this pull request Mar 22, 2024
Closed
@hengshan123 hengshan123 mentioned this pull request Mar 22, 2024
Closed
@gracesolver gracesolver mentioned this pull request Jun 9, 2024
Open
@Xiao0219 Xiao0219 mentioned this pull request Aug 1, 2024
Open
@janiceylau janiceylau mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ablattmann ablattmann Awaiting requested review from ablattmann

@timudk timudk Awaiting requested review from timudk

1 more reviewer

@jenuk jenuk jenuk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ablattmann ablattmann

@timudk timudk

@benjaminaubin benjaminaubin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminaubin @ablattmann @jenuk @timudk