Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Minimize re-exports from __init__ files" #63

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

timudk
Copy link
Contributor

@timudk timudk commented Jul 25, 2023

Temporarily revert #44 to do some internal testing.

@akx
Copy link
Contributor

akx commented Jul 26, 2023

@timudk Again, why? Did #44 break something – if it did, what did it break? I'm genuinely curious. Please also see the discussion on #44 for a rationale to implement it in the first place.

You could revert all of these for internal testing on another branch.

(Also, if you want to chat in a more sync way, I've been trying to reach out to people on the Stable Foundation Discord's #developers channel; my Discord handle is akx_)

@jenuk jenuk merged commit 7934245 into main Jul 26, 2023
@jenuk
Copy link
Contributor

jenuk commented Jul 26, 2023

Hi @akx sorry for this again. We have sent you an email explaining the current status.

@benjaminaubin benjaminaubin deleted the revert-44-minimize-re-exports branch July 26, 2023 10:10
LinearFalcon pushed a commit to LinearFalcon/generative-models that referenced this pull request Jul 6, 2024
SevanBrodjian pushed a commit to SevanBrodjian/sd-latent-exploration that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants