-
Notifications
You must be signed in to change notification settings - Fork 29
feat: compact header and add GitHub icon #57 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: compact header and add GitHub icon #57 #59
Conversation
WalkthroughThe pull request modifies the header layout in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/page.tsx(2 hunks)
🔇 Additional comments (1)
app/page.tsx (1)
105-111: Compact header sizing looks consistent; just sanity-check mobile wrapping.With
text-2xl+ the right-side actions, verify the header doesn’t wrap awkwardly on small widths (e.g., iPhone SE / 320px) and that the sticky header height stays usable.
| <div className="max-w-6xl mx-auto px-4 py-3 flex justify-between items-center"> | ||
| <div> | ||
| <h1 className="text-5xl font-bold font-playfair bg-gradient-to-r from-[#228B22] via-[#5A981A] via-[#91A511] via-[#ADAC0D] via-[#E4B905] to-[#FFBF00] bg-clip-text text-transparent drop-shadow-sm leading-tight pb-2"> | ||
| <h1 className="text-2xl font-bold font-playfair bg-gradient-to-r from-[#228B22] via-[#5A981A] via-[#91A511] via-[#ADAC0D] via-[#E4B905] to-[#FFBF00] bg-clip-text text-transparent drop-shadow-sm leading-tight"> | ||
| Stable Viewpoints | ||
| </h1> | ||
| <p className="text-gray-600 mt-2 text-lg">Independent Articles about Stability</p> | ||
| <p className="text-gray-600 text-sm">Independent Articles about Stability</p> | ||
| </div> | ||
| <div className="flex items-center gap-6"> | ||
| <a | ||
| href="https://github.com/StabilityNexus/StableViewpoints" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="bg-black text-white p-2 rounded-full hover:bg-gray-800 transition-colors" | ||
| > | ||
| <Github className="w-5 h-5" /> | ||
| </a> | ||
| <Link | ||
| href="/submit" | ||
| className="inline-flex items-center gap-2 bg-gradient-to-r from-[#228B22] to-[#91A511] hover:from-[#3E921E] hover:to-[#ADAC0D] text-white px-4 py-2 text-sm font-semibold transition-all duration-300 shadow-lg hover:shadow-xl transform hover:-translate-y-0.5" | ||
| > | ||
| Submit an Article | ||
| </Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add accessible name + focus styles for the icon-only GitHub link.
Right now the <a> contains only an SVG, so screen readers may announce it as an unlabeled “link”, and keyboard users don’t get a clear focus indicator.
<div className="flex items-center gap-6">
<a
href="https://github.com/StabilityNexus/StableViewpoints"
target="_blank"
rel="noopener noreferrer"
- className="bg-black text-white p-2 rounded-full hover:bg-gray-800 transition-colors"
+ aria-label="Stable Viewpoints on GitHub"
+ title="Stable Viewpoints on GitHub"
+ className="bg-black text-white p-2 rounded-full hover:bg-gray-800 transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:ring-black"
>
<Github className="w-5 h-5" />
</a>
<Link
href="/submit"
- className="inline-flex items-center gap-2 bg-gradient-to-r from-[#228B22] to-[#91A511] hover:from-[#3E921E] hover:to-[#ADAC0D] text-white px-4 py-2 text-sm font-semibold transition-all duration-300 shadow-lg hover:shadow-xl transform hover:-translate-y-0.5"
+ className="inline-flex items-center gap-2 rounded-md bg-gradient-to-r from-[#228B22] to-[#91A511] hover:from-[#3E921E] hover:to-[#ADAC0D] text-white px-4 py-2 text-sm font-semibold transition-all duration-300 shadow-lg hover:shadow-xl transform hover:-translate-y-0.5 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:ring-[#228B22]"
>
Submit an Article
</Link>
</div>🤖 Prompt for AI Agents
In app/page.tsx around lines 105 to 126, the GitHub anchor is icon-only and
lacks an accessible name and keyboard focus styles; add an accessible label by
either adding aria-label="Open StableViewpoints GitHub" to the <a> or inserting
a visually hidden span (className="sr-only") with that text, and enhance
keyboard focus visibility by adding focus-visible classes to the anchor's
className (for example: focus:outline-none focus-visible:ring-2
focus-visible:ring-offset-2 focus-visible:ring-black or equivalent Tailwind
focus classes) so screen readers announce the link and keyboard users see a
clear focus indicator.
Stable.Viewpoints.-.Google.Chrome.2025-12-14.01-35-16.mp4
there is proof of and before is like

so its a better choice
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.