Added the app design figma file #20
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughIntroduces extension discovery infrastructure for the Zplit package by adding two new files to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.dart_tool/extension_discovery/README.md.dart_tool/extension_discovery/vs_code.jsondesign/Zplit - Aradhya.fig
🧰 Additional context used
🪛 LanguageTool
.dart_tool/extension_discovery/README.md
[style] ~23-~23: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...o access information from this folder. Feel free to delete this folder --------------------...
(FEEL_FREE_TO_STYLE_ME)
🪛 markdownlint-cli2 (0.18.1)
.dart_tool/extension_discovery/README.md
10-10: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
| * Do not read (or rely) the contents of this folder. | ||
| * Do write to this folder. |
There was a problem hiding this comment.
Fix list indentation in Markdown.
The unordered list items at lines 10–11 have incorrect indentation (1 space instead of 0). This violates Markdown best practices and may cause rendering issues in some parsers.
🔎 Proposed fix
-DO NOT USE THIS FOLDER
+DO NOT USE THIS FOLDER
-----------------------
- * Do not read (or rely) the contents of this folder.
- * Do write to this folder.
+* Do not read (or rely) the contents of this folder.
+* Do NOT write to this folder.Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
10-10: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
🤖 Prompt for AI Agents
In .dart_tool/extension_discovery/README.md around lines 10 to 11 the unordered
list items are indented with one extra leading space; remove the leading space
so each bullet asterisk begins at column 0 (no indentation) to correct the
Markdown list indentation and ensure consistent rendering.
| ---------------------- | ||
|
|
||
| * Do not read (or rely) the contents of this folder. | ||
| * Do write to this folder. |
There was a problem hiding this comment.
Clarify the intent: line 11 should say "Do NOT write."
Line 11 currently reads "Do write to this folder" but given the section heading "DO NOT USE THIS FOLDER" and the surrounding documentation, this appears to be a typo. It should state "Do NOT write to this folder" to be consistent with the stated purpose (the cache is managed by the extension_discovery system, not by users).
The proposed fix above addresses both the indentation and this clarification.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
11-11: Unordered list indentation
Expected: 0; Actual: 1
(MD007, ul-indent)
🤖 Prompt for AI Agents
In .dart_tool/extension_discovery/README.md around line 11, the sentence "Do
write to this folder" contradicts the section heading and should be corrected to
"Do NOT write to this folder"; update that line to the negated form and fix
indentation if needed so it matches surrounding formatting and the intent that
the folder is managed by extension_discovery and should not be manually written
to.
| @@ -0,0 +1 @@ | |||
| {"version":2,"entries":[{"package":"zplit","rootUri":"../","packageUri":"lib/"}]} No newline at end of file | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if .dart_tool is in .gitignore
if [ -f .gitignore ]; then
echo "=== Checking .gitignore for .dart_tool ==="
grep -n "\.dart_tool" .gitignore || echo ".dart_tool NOT found in .gitignore"
else
echo ".gitignore file not found"
fi
# List what's currently being tracked in .dart_tool
echo -e "\n=== Files tracked in .dart_tool ==="
git ls-files .dart_tool/ 2>/dev/null || echo "No files tracked in .dart_tool"
# Also check the directory structure
echo -e "\n=== .dart_tool directory structure ==="
ls -la .dart_tool/ 2>/dev/null | head -20 || echo ".dart_tool directory does not exist in working directory"Repository: StabilityNexus/Zplit
Length of output: 868
Remove .dart_tool/ directory and add it to .gitignore immediately.
The .dart_tool/ directory is being tracked in version control but should not be. These are auto-generated build and cache files created by Dart/Flutter tools (package_config.json, package_graph.json, web_plugin_registrant.dart, vs_code.json, etc.). They are already in the repository:
- Add
.dart_tool/to.gitignore - Run
git rm -r --cached .dart_tool/to remove these files from version control - Commit the changes
Keeping these files committed causes unnecessary repository bloat, merge conflicts in team environments, and violates Dart/Flutter project conventions.
🤖 Prompt for AI Agents
In .dart_tool/extension_discovery/vs_code.json around lines 1 to 1: the
.dart_tool directory is committed but should be ignored; add a line
".dart_tool/" to the repository .gitignore (or ensure it exists), then run git
rm -r --cached .dart_tool/ to remove the tracked files while keeping them
locally, and commit the updated .gitignore and removal so .dart_tool/ is no
longer tracked.
ara2105
force-pushed
the
Aradhya-app-design
branch
from
cc9cfa9 to
0fb9395
Compare
|
Please rename the file to zplit-design, and for future reference, not that all PRs must be raised to dev instead of main |
|
Okay @M4dhav Understood, will do the asked. |
ara2105
force-pushed
the
Aradhya-app-design
branch
from
d06e092 to
44551ca
Compare
|
please rename it to exactly |
2 participants
Fixes #18
Here is the Zplit app design - https://www.figma.com/design/MzAfV4ex1zItWjsOu4Tk5I/Zplit---Aradhya?t=SvChlLcttDv30Swo-1
Created a new folder and added the .fig file for the same.
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.