Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gym 0.21 #7

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Upgrade to Gym 0.21 #7

merged 2 commits into from
Mar 22, 2022

Conversation

AdamGleave
Copy link
Contributor

@AdamGleave AdamGleave commented Feb 4, 2022

Change occurrences of Pendulum-v0 to Pendulum-v1, and fix one loading bug (needs pkl suffix) in advanced_saving_loading.ipynb

I have not verified the other notebooks (perhaps we should make unit tests for them with pytest-notebook?), but I looked at all environment names with regex -v[0-9] and all of them seem to still be present in newest Gym. So should work.

@AdamGleave AdamGleave changed the title Upgrade to Upgrade to Gym 0.21 Feb 4, 2022
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =) (I tested the rest and fixed #8 )

@AdamGleave AdamGleave merged commit 031775d into sb3 Mar 22, 2022
@araffin
Copy link
Member

araffin commented Mar 22, 2022

@AdamGleave wait, I wanted to release SB3 1.5.0 first

@araffin araffin deleted the upgrade-gym-021 branch March 22, 2022 17:35
@AdamGleave
Copy link
Contributor Author

ah sorry, feel free to revert!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants