Merge pull request #14 from StackAdapt/jc/ondelete

Fix(ITE-146) Refactored structure for OnDelete
StackAdapt · Nov 20, 2024 · acaccc8 · acaccc8
2 parents 0409391 + 9a11a42
commit acaccc8
Showing 1 changed file with 15 additions and 22 deletions.
diff --git a/packages/destination-actions/src/destinations/stackadapt-audiences/index.ts b/packages/destination-actions/src/destinations/stackadapt-audiences/index.ts
@@ -62,7 +62,6 @@ const destination: DestinationDefinition<Settings> = {
   onDelete: async (request, { payload }) => {
     const userId = payload.userId
     const formattedExternalIds = `["${userId}"]`
-
     const syncId = sha256hash(String(userId))
 
     const mutation = `mutation {
@@ -78,31 +77,25 @@ const destination: DestinationDefinition<Settings> = {
       }
     }`
 
-    try {
-      const response = await request(GQL_ENDPOINT, {
-        method: 'POST',
-        headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({ query: mutation })
-      })
-
-      const result = await response.json()
+    const response = await request(GQL_ENDPOINT, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({ query: mutation })
+    })
 
-      if (result.data.deleteProfilesWithExternalIds.userErrors.length > 0) {
-        const errorMessages = result.data.deleteProfilesWithExternalIds.userErrors.map((e: any) => e.message).join(', ')
-        throw new IntegrationError(`Profile deletion was not successful: ${errorMessages}`, 'DELETE_FAILED', 400)
+    const result: {
+      data: {
+        deleteProfilesWithExternalIds: {
+          userErrors: { message: string }[]
+        }
       }
+    } = await response.json()
 
-      return result
-    } catch (error) {
-      if (error instanceof IntegrationError) {
-        throw error
-      }
-      throw new IntegrationError(
-        `Unexpected error occurred in onDelete: ${error instanceof Error ? error.message : String(error)}`,
-        'UNKNOWN_ERROR',
-        400
-      )
+    if (result.data.deleteProfilesWithExternalIds.userErrors.length > 0) {
+      const errorMessages = result.data.deleteProfilesWithExternalIds.userErrors.map((e) => e.message).join(', ')
+      throw new IntegrationError(`Profile deletion was not successful: ${errorMessages}`, 'DELETE_FAILED', 400)
     }
+    return result
   },
 
   actions: {