Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

somehow not adding the returnurl param went missing #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rschrieken
Copy link
Contributor

this fixes https://meta.stackexchange.com/questions/256042/sede-login-redirects-to-front-page-rather-than-returning

I've simply copied the build-up of the returnUrl query parameter as it was done in Views\Account\LogInActiveDirectory.cshtml

Tested with the SE OpenId provider. Any other provider that supports keeping the returnurl intact would work similar.

@NickCraver
Copy link
Contributor

Note for self: we need to ensure there's not an open redirect here on the server implementation (relative or current domain should be allowed only) - want to investigate this before merging in another path to it.

@NickCraver NickCraver self-assigned this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants