-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Closing initial cluster discovery connection #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing initial cluster discovery connection #1741
Conversation
|
Merging main in here for the connection/test fixes and a better time :) |
|
Identified more testing issues (around repo permissions - new guards against cypto mining) - merging in master for a better time yet again. |
…st of ips returned by cluster nodes command)
Thank you @NickCraver for merging the improvements in here :) |
|
I have fixed my code as well and now all tests are passing. |
…ection after a connection failure.
|
This fix will require more changes and doesn't seems to be as straight forward as I had thought where various parts of the system could depend on the discovery connection. Possible fix is to introduce a configuration option that will allow client application to specify closing the discovery connection I am closing the PR for now and will revisit if there is a strong need for us to close this connection. |
A mux to a clustered cache is created by specifying one of the endpoints in the cluster. SE.Redis then runs the CLUSTER NODES command to connect to individual nodes of the cluster. The initial connection to discover cluster nodes is not used for any client application commands after the initial discovery. This PR proposes to close this connection after discovery of the nodes in the cluster, which will help to reduce the total number of connections from each of the multiplexer when running at scale.