chore: Replaces string interpolation with structured logging - ServerEndPoint #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates Redis server endpoint logging from string interpolation to LoggerMessage attributes for better performance and structured logging support. Adds 14 new LoggerMessage methods for server connection lifecycle events including handshake, authentication, configuration, and buffer operations. Uses ServerEndPointLogValue wrapper to ensure consistent server representation in logs while maintaining type safety.
5 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mgravell
reviewed
Jul 23, 2025
Collaborator
Other than that: looks great, thanks |
mgravell
requested changes
Jul 23, 2025
Collaborator
mgravell
left a comment
mgravell
left a comment
There was a problem hiding this comment.
tie-breaker NRE?
target-type new(...)?
if neither make sense: let me know
Contributor
Author
|
I'll add these changes |
Changes parameter type from string to RedisKey in logging method to maintain type consistency throughout the tie-breaker request flow. Simplifies object instantiation using target-typed new expression.
Contributor
Author
|
@mgravell ready |
mgravell
approved these changes
Jul 23, 2025
Collaborator
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #2899
Migrates Redis server endpoint logging from string interpolation to LoggerMessage attributes for better performance and structured logging support.
Adds 14 new LoggerMessage methods for server connection lifecycle events including handshake, authentication, configuration, and buffer operations.
Uses ServerEndPointLogValue wrapper to ensure consistent server representation in logs while maintaining type safety.
github-copilot prompt used:
