-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Strategy ADR #1195
Testing Strategy ADR #1195
Conversation
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I don't have any issues with this ADR. I'll review your PR to see how I feel about the technologies you've chosen and come back to approve this PR afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADR looks good to me! I'll take the same approach as Ben and review the other testing PR before approving this one.
@b-kelly @dancormier Thanks for the review, the implementation PR should now be working also in windows environments. Looking forward to your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the implementation PR and I like the approach this describes. Approved there, so approving here. 🦐 it!
This PR adds an initial testing strategy ADR for Stacks.
It is supported by this Testing PR (implementation): #1194