Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Strategy ADR #1195

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Testing Strategy ADR #1195

merged 3 commits into from
Dec 15, 2022

Conversation

giamir
Copy link
Contributor

@giamir giamir commented Nov 28, 2022

This PR adds an initial testing strategy ADR for Stacks.
It is supported by this Testing PR (implementation): #1194

@giamir giamir added the adr Architecture Decision Record label Nov 28, 2022
@giamir giamir requested a review from a team November 28, 2022 15:37
@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit a1605ff
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/639b038821e0b6000811b78a
😎 Deploy Preview https://deploy-preview-1195--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@b-kelly b-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I don't have any issues with this ADR. I'll review your PR to see how I feel about the technologies you've chosen and come back to approve this PR afterwards

Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADR looks good to me! I'll take the same approach as Ben and review the other testing PR before approving this one.

@giamir
Copy link
Contributor Author

giamir commented Dec 5, 2022

@b-kelly @dancormier Thanks for the review, the implementation PR should now be working also in windows environments. Looking forward to your feedback.

Copy link
Collaborator

@b-kelly b-kelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the implementation PR and I like the approach this describes. Approved there, so approving here. 🦐 it!

@giamir giamir merged commit cd0ec76 into develop Dec 15, 2022
@giamir giamir deleted the gbuoncristiani/testing-strategy-adr branch December 15, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adr Architecture Decision Record
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants