Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NS1: URFLWD is deprecated #3076

Closed
costasd opened this issue Aug 8, 2024 · 3 comments · Fixed by #3078
Closed

NS1: URFLWD is deprecated #3076

costasd opened this issue Aug 8, 2024 · 3 comments · Fixed by #3078

Comments

@costasd
Copy link
Contributor

costasd commented Aug 8, 2024

While working on #2815, I found out that the URLFWD record type (what we call NS1_URLFWD in dnscontrol) is being deprecated by IBM/NSONE.

Essentially, the current status is:

  • No docs anymore, just a hint that this is going to be replaced by a new "REDIRECT" type source
  • No way to configure (=add new/edit existing) them through the portal
  • API still works, but can stop accepting the record anytime

I'm tempted to just remove all relevant code from the provider and replace with a message for any people still using it, but maybe warrants a deprecation notice in the next release and removal in next++. Not sure though, it's probably not that many people using it, but that's just a hunch.

Any opinions?

@tlimoncelli
Copy link
Contributor

There are a couple ways to do this:

  1. Announce NS1_URLFWD is going away in the docs, have it print a warning, and remove the code when the API disappears.
  2. Add code so that NS1_URLFWD generates a REDIRECT in addition and stop updating URLFWD.

The first is probably less work. I'm ok with either.

costasd added a commit to costasd/dnscontrol that referenced this issue Aug 12, 2024
@costasd
Copy link
Contributor Author

costasd commented Aug 12, 2024

Thanks. Given that REDIRECT isn't live yet nor fully documented, I will go with the first option. #3078 adds this warning and there's #3075 open for the docs

@tlimoncelli
Copy link
Contributor

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants