-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: HASH() adds hashing functions to dnsconfig.js language #3085
New Feature: HASH() adds hashing functions to dnsconfig.js language #3085
Conversation
Sounds like a reasonable feature to add. Some changes I'd like to see in the PR:
|
Thanks for the feedback, I've added your suggestions. |
Looks great! Thanks for the fast response. Please run CC @cafferata to review the docs. |
@tlimoncelli, thanks for the mention. @fuero, this new dnscontrol/documentation/SUMMARY.md Lines 22 to 27 in 7b28609
|
- algorithm | ||
- value | ||
parameter_types: | ||
algorithm: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could provide TypeScript autocomplete with the possible algorithm:
algorithm: string | |
algorithm: '"SHA1" | "SHA256" | "SHA512"' |
@cafferata done, thanks! |
Great when feedback is processed so quickly. Thank you. If you would like to view the preview yourself, you can do so at the URL below: |
Looks good to me! Thanks for adding this feature! |
Having access to SHA1 would be great when managing catalog zones:
So this PR adds a
HASH
function to Javascript following the above example.