Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes Auth Method #21

Conversation

hreeder
Copy link

@hreeder hreeder commented May 11, 2021

Stackstorm-ha, by default, runs in Kubernetes (which is how I've got ST2 deployed). This PR should add support for Vault's Kubernetes auth method to the pack.

Draft, while I test it locally on my own deployment, but to give you the heads up this is coming.

README.md Outdated Show resolved Hide resolved
@cognifloyd
Copy link
Member

cognifloyd commented May 11, 2021

Oooh. This is pretty cool! Thanks!
config.schema.yaml will need to be updated to add role and auth_method=kubernetes.

@hreeder
Copy link
Author

hreeder commented May 11, 2021

Oooh. This is pretty cool! Thanks!
config.schema.yaml will need to be updated to add role and auth_method=kubernetes.

Thanks for the catch, updated.

@hreeder hreeder marked this pull request as ready for review May 26, 2021 10:19
@hreeder
Copy link
Author

hreeder commented May 26, 2021

@cognifloyd This should be good for review now. It's working in my environments suitably and we can access and retrieve vault secrets as necessary within our K8s environments.

I've also added a generic auth_mount_point config parameter as our setup makes use of custom mount points for different environments.

@cognifloyd
Copy link
Member

#23 should fix the test errors here.

@cognifloyd
Copy link
Member

#23 was just merged. Please merge in master. That should fix the tests.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nzlosh
Copy link
Contributor

nzlosh commented Apr 4, 2024

Closing as stale. Reopen with signed CLA and rebased master to have this PR merged.

@nzlosh nzlosh closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants