-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup a bit and use hubot-botframework for MS Teams support #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blag
force-pushed
the
add-msteams
branch
2 times, most recently
from
March 26, 2019 10:39
5700ec0
to
540dfc6
Compare
blag
force-pushed
the
add-msteams
branch
3 times, most recently
from
March 28, 2019 08:21
865478c
to
034e52c
Compare
This was referenced Mar 29, 2019
Kami
reviewed
Mar 29, 2019
Kami
reviewed
Mar 29, 2019
Kami
approved these changes
Mar 29, 2019
LGTM, looking forward to integration / end to end tests in the future 👍 |
@blag Worth also updating CHANGELOG record with this new addition: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.2.2
createExecution
function tosendAliasExecutionRequest
so it's a bit clearer how the function is different thanexecuteCommand
source_context
insendAliasExecutionRequest
functionnormalizeAddressee
functions on adapters