update builtin collections imports to be forward-compatible with Python3.10+ #253

AndroxxTraxxon · 2023-05-02T15:38:14Z

Python 3.10 removes the deprecated aliases to the Collections abstract base classes, which was done in Python 3.3
Python3.10 Changelog:

Remove deprecated aliases to Collections Abstract Base Classes from the collections module. (Contributed by Victor Stinner in bpo-37324.)

This change refactors the imports in 2 files that were still using this deprecated import style to one that is more globally supported.

https://docs.python.org/3/whatsnew/3.10.html#removed

updating workflow to user currently supported versioning syntax

The setup-python action@v2 does not accommodate for the fact that there is no python3.6 release for ubuntu 22, so we need to upgrade the version to allow for backwards compatibility.

…reqt's

AndroxxTraxxon · 2023-05-02T16:19:45Z

I had to tweak the tox.yml build because ubuntu-latest no longer supports python3.6, so I tried to set up the test matrix to cover all the appropriate python versions across multiple ubuntu versions

…till being run here.

missed an error message on a test that looks for the name that changed.

arm4b

LGTM overall

We need an updated changelog and a 🟢 build to merge it.
I know it's not related to your PR, but if you have a few cycles to look into it, - that'll help to move forward with it.

AndroxxTraxxon · 2023-09-20T16:34:46Z

I've updated the changelog as requested, but I have no idea where to start looking for these tests. do you have any idea where a good place to start would be?

arm4b · 2023-09-20T18:39:20Z

From https://github.com/StackStorm/orquesta/actions, the latest green build was in the https://github.com/StackStorm/orquesta/pull/256/files

I think it makes sense to fix master branch first, by taking from that PR adjustments to the GH Actions and tests. Once the master is green, the build in this PR would be easier to adjust.

CHANGELOG.rst

arm4b · 2023-09-20T18:44:06Z

.github/workflows/tox.yml

+        os: [ubuntu-latest, ubuntu-22.04, ubuntu-20.04]
+        exclude: 
+          - python-version: "3.10"
+            os: ubuntu-20.04
+          - python-version: "3.6"
+            os: ubuntu-22.04
+          - python-version: "3.6"
+            os: ubuntu-latest
+    runs-on: ${{matrix.os}}


Because we're testing python and not OS at this level, from this build matrix, I think it makes sense to just have 1 environment for reach python version:

3.6, ubuntu-20.04

3.8, ubuntu-22.04

should simplify it a bit, unless you had specific reason to have a wider build matrix

Here https://github.com/StackStorm/orquesta/pull/256/files#diff-8a1944567ec5d9e12aaaac28489c47e6567e13b58d861815379f9b8d3aeb2623R15 the build was green by using ubuntu-20.04 environment for both py3.6 and py3.8.
Maybe that's the reason of so many unit test fails in this PR build? Worth checking.

Thanks, those are some really useful points.

@AndroxxTraxxon The CI is fixed here #257 and is now ✅ on master, thanks to @amanda11 and @nzlosh.

Please sync your work with the master branch.

Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>

remove Python 3.12 from testing matrix

nzlosh · 2023-10-10T15:17:42Z

I'd be inclined to drop 3.6 from the matrix and add py3.9 + py.311

Remove tests for 3.10 -- the package isn't ready yet.

AndroxxTraxxon · 2023-10-10T17:22:49Z

I'd be include to drop 3.6 from the matrix and add py3.9 + py.311

I'd be okay adding 3.9, but the project isn't ready for 3.10+. Between the nose tests and the pip version, there are still a bunch of items that need to be addressed before 3.10 is possible.

CLAassistant · 2023-10-10T19:41:35Z

All committers have signed the CLA.

…king

AndroxxTraxxon · 2023-10-10T20:44:03Z

Per today's TSC meeting, I dropped support (and testing) for Python 3.6, and added testing against 3.9, 3.10, and 3.11

arm4b · 2023-10-10T23:46:06Z

I think we still need python3.6 for releasing a v3.8.1 patch version first which should be backwards-compatible.
We can drop Python3.6 for the bigger release v3.9.0 after that.

So please keep the py3.6 in this PR which could be dropped after releasing a patch version.

Alternative is to postpone merging this one until making an orquesta patch version to be used in the stackstorm/st2.

…pping support.

arm4b

Thanks a lot, great work! 💯

nzlosh

👍 Great job! LGTM

AndroxxTraxxon · 2023-10-12T00:23:18Z

What else needs to happen to merge this?

nzlosh · 2023-10-12T04:53:22Z

@armab I initially asked for support for py3.11 and drop py3.6 because an st2 3.8.1 release wasn't a consideration. As the 3.8.1 release manager, do you want to merge this for st2 3.8.1 or hold for st2 3.9?

amanda11 · 2023-10-12T15:21:17Z

@armab I initially asked for support for py3.11 and drop py3.6 because an st2 3.8.1 release wasn't a consideration. As the 3.8.1 release manager, do you want to merge this for st2 3.8.1 or hold for st2 3.9?

I think we should merge, but @armab up to you. This just adds us running the tests on the extra python, and doesn't affect us still releasing ST2 only on 3.6 and 3.8 for 3.8.1 release.

AndroxxTraxxon · 2023-10-17T11:58:46Z

Hi @armab, I noticed that you did add this PR to the 3.8.1 release tracker. Were you looking for anything else in the PR before we merge it, or did we want to leave this until st2 v3.9.0?

arm4b · 2023-10-18T19:12:57Z

Yeah, I think it's OK to use the same orquesta = 1.6.0 (to be released) for both v3.8.1 and potentially v3.9.0 as there were no major additions or breaking changes. This one should work fine with py3.6 as well.

Merging it, thanks everyone!

AndroxxTraxxon added 7 commits May 2, 2023 09:00

Update workflow.py to be python3.10+ compatible

6772632

Update base.py to be python3.10+ compatible

c030c33

Update base.py to be compatible back to 3.6

524eff2

Update workflow.py to also be backwards compatible to python 3.6

0d75e0b

Update tox.yml

5fda72b

updating workflow to user currently supported versioning syntax

Update tox.yml for old Python compatibility

f105c00

The setup-python action@v2 does not accommodate for the fact that there is no python3.6 release for ubuntu 22, so we need to upgrade the version to allow for backwards compatibility.

Update tox.yml with more comprehensive test matrix to fit dependency …

79eb36c

…reqt's

AndroxxTraxxon added 3 commits May 2, 2023 11:41

Update tox.yml -- move exclusions to inside the strategy matrix

209f988

Update tox.yml - removing Python3.10 testing because nose tests are s…

4167882

…till being run here.

Update test_task_rendering_for_with_items.py

d0d977d

missed an error message on a test that looks for the name that changed.

AndroxxTraxxon mentioned this pull request Jun 20, 2023

Futureproofing: Removing distutils dependencies StackStorm/st2#5992

Merged

AndroxxTraxxon mentioned this pull request Sep 13, 2023

TSC Meeting (12th Sept 2023) StackStorm/community#124

Closed

arm4b approved these changes Sep 19, 2023

View reviewed changes

arm4b added the enhancement label Sep 19, 2023

Update CHANGELOG.rst

97e3244

arm4b reviewed Sep 20, 2023

View reviewed changes

CHANGELOG.rst Outdated Show resolved Hide resolved

arm4b reviewed Sep 20, 2023

View reviewed changes

Update CHANGELOG.rst

e916994

Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>

arm4b mentioned this pull request Oct 7, 2023

TSC Meeting (10 Oct 2023) - Fixing builds, Upstream dependencies, stackstorm.com, Python difficulties, new OS support StackStorm/community#125

Closed

13 tasks

AndroxxTraxxon added 4 commits October 10, 2023 09:47

Merge branch 'master' into master

4cdefb6

Update tox.yml

5bb925b

Update tox.yml

15b4ee7

remove Python 3.12 from testing matrix

Update requirements-ci.txt

9836b06

Update tox.yml

7ba729d

Remove tests for 3.10 -- the package isn't ready yet.

replacing nose with pytest, testing python 3.8-3.11

1a70b40

AndroxxTraxxon added 6 commits October 10, 2023 14:47

correcting gitlab ci matrix

015f618

tweak the pytest command

91106ff

attempting python path patching for docs schema generation

410b034

switching to use development mode install for docs generation

abda276

applying formatting, attempting more path shenanigans to get docs wor…

e5917ae

…king

doing some cleanup for consistency

f20280b

re-add Python 3.6 to the test matrix for the patch release before dro…

12ee053

…pping support.

arm4b approved these changes Oct 11, 2023

View reviewed changes

nzlosh approved these changes Oct 11, 2023

View reviewed changes

amanda11 approved these changes Oct 12, 2023

View reviewed changes

arm4b merged commit efd5bb4 into StackStorm:master Oct 18, 2023
5 checks passed

arm4b mentioned this pull request Dec 11, 2023

Add David Culbreth (AndroxxTraxxon) to Contributors StackStorm/st2#6088

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update builtin collections imports to be forward-compatible with Python3.10+ #253

update builtin collections imports to be forward-compatible with Python3.10+ #253

AndroxxTraxxon commented May 2, 2023

AndroxxTraxxon commented May 2, 2023

arm4b left a comment

AndroxxTraxxon commented Sep 20, 2023

arm4b commented Sep 20, 2023

arm4b Sep 20, 2023

arm4b Sep 20, 2023

AndroxxTraxxon Sep 21, 2023

arm4b Sep 25, 2023

nzlosh commented Oct 10, 2023 •

edited

Loading

AndroxxTraxxon commented Oct 10, 2023

CLAassistant commented Oct 10, 2023 •

edited

Loading

AndroxxTraxxon commented Oct 10, 2023

arm4b commented Oct 10, 2023 •

edited

Loading

arm4b left a comment

nzlosh left a comment

AndroxxTraxxon commented Oct 12, 2023

nzlosh commented Oct 12, 2023 •

edited

Loading

amanda11 commented Oct 12, 2023

AndroxxTraxxon commented Oct 17, 2023

arm4b commented Oct 18, 2023

update builtin collections imports to be forward-compatible with Python3.10+ #253

update builtin collections imports to be forward-compatible with Python3.10+ #253

Conversation

AndroxxTraxxon commented May 2, 2023

AndroxxTraxxon commented May 2, 2023

arm4b left a comment

Choose a reason for hiding this comment

AndroxxTraxxon commented Sep 20, 2023

arm4b commented Sep 20, 2023

arm4b Sep 20, 2023

Choose a reason for hiding this comment

arm4b Sep 20, 2023

Choose a reason for hiding this comment

AndroxxTraxxon Sep 21, 2023

Choose a reason for hiding this comment

arm4b Sep 25, 2023

Choose a reason for hiding this comment

nzlosh commented Oct 10, 2023 • edited Loading

AndroxxTraxxon commented Oct 10, 2023

CLAassistant commented Oct 10, 2023 • edited Loading

AndroxxTraxxon commented Oct 10, 2023

arm4b commented Oct 10, 2023 • edited Loading

arm4b left a comment

Choose a reason for hiding this comment

nzlosh left a comment

Choose a reason for hiding this comment

AndroxxTraxxon commented Oct 12, 2023

nzlosh commented Oct 12, 2023 • edited Loading

amanda11 commented Oct 12, 2023

AndroxxTraxxon commented Oct 17, 2023

arm4b commented Oct 18, 2023

nzlosh commented Oct 10, 2023 •

edited

Loading

CLAassistant commented Oct 10, 2023 •

edited

Loading

arm4b commented Oct 10, 2023 •

edited

Loading

nzlosh commented Oct 12, 2023 •

edited

Loading