Refactor StackStorm yum/apt repo

[nmaludy]

When working on revamping the integration tests, i noticed that the PackageCloud module was not idempotent (yuck). Every time Puppet would run it would force a refresh of the Yum and Apt caches causing issues when testing for idempotence.

This PR:

• Removes the reliance on the PackageCloud module
• Creates a <module>::repo class that is idiomatic to many of the mainstream Puppet repos
• Utilize the yumrepo and apt modules to install the appropriate repository for the given OS

[nmaludy]

Closes #236

[nmaludy]

@armab this one is ready when you have some free time (no rush)

[arm4b]

Do we have idempotence check in CI or is it a strong requirement for Puppet module?

I'm not confident rewrite like that is the best approach. It would be really nice to reuse the original packagecloud module instead of re-writing all the things.

Maybe there is a reason behind the way it works or a bug in PackageCloud module itself?
Would be nice at least to report a bug in their Puppet module.

[nmaludy]

@armab let me answer these in order:

• We do not have an idempotence check right now, but it's easy to do in Litmus + ServerSpec, which is where i'm trying to get it. I"m trying to make that PR less of a "huge blast" and break it up into chunks so it's easier to digest.

• The original packagecloud module is really terrible and does things in totally the wrong way (non-puppet way). All of the other mainstream modules do it like i did (where i got my inspiration), see links below:

https://github.com/voxpupuli/puppet-nodejs/blob/master/manifests/repo/nodesource.pp
https://github.com/voxpupuli/puppet-mongodb/blob/master/manifests/repo.pp
https://github.com/voxpupuli/puppet-jenkins/blob/master/manifests/repo.pp

[arm4b]

OK, I made a quick research and computology/computology-packagecloud#26 answers my question with latest changes made to PackageCloud module 3 years ago.

LGTM 👍