Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #329

Closed
wants to merge 2 commits into from
Closed

Conversation

rush-skills
Copy link
Member

Currently the puppet-st2 builds are failing due to an error in the st2::profiles::python with the following error in all integrations tests.

Error: Evaluation Error: Error while evaluating a Resource Statement, Class[Python]: has no parameter named 'manage_virtualenv_package' (file: /tmp/kitchen/modules/st2/manifests/profile/python.pp, line: 51, column: 5)

By removing manage_virtualenv_package parameter for python class, the error is fixed and the tests are green again

@rush-skills rush-skills marked this pull request as draft June 23, 2021 15:54
@nmaludy
Copy link
Member

nmaludy commented Jul 6, 2021

@rush-skills how's your internal approval going for merges?

@bishopbm1
Copy link
Collaborator

@nmaludy @rush-skills Once a new tag gets created and published to the forge this will be solved by #333

@rush-skills
Copy link
Member Author

@nmaludy It is still WIP, will take a couple of weeks more I suppose. I will update once it is done.
@bishopbm1 Thanks, if #333 fixes this, I will close this PR and let that one get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants