Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 20.04 and refactoring #335

Merged
merged 53 commits into from
Sep 15, 2021
Merged

Ubuntu 20.04 and refactoring #335

merged 53 commits into from
Sep 15, 2021

Conversation

rush-skills
Copy link
Member

Changes to

  • add support for Ubuntu 20.04
  • MongoDB 4.4
  • cleaning up some old code and remove old-style references
  • adding some documentation for puppet module development\
  • fixing test suite

rush-skills added 30 commits June 23, 2021 13:27
@rush-skills
remove manage_virtualenv_package param from python profile
62327bf
@rush-skills
update changelog
cf567a3
@rush-skills
Remove unused conf file
8bbe000
@rush-skills
remove travis references
cfb78f4
@rush-skills
clean old style :: references
08e7ed9
@rush-skills
fix old style fact reference in selinux profile
57c7453
@rush-skills
cleanup build docs
640150e
@rush-skills
update changelog
8fc2d82
@rush-skills
add dev todo to remove anchor
29975ad
@rush-skills
update to ubuntu 20.04
2a984a3
@rush-skills
add ubuntu20 to kitchen platforms
ff25573
@rush-skills
add unstable testing channel for focal
a0d2c8f
@rush-skills
update github action build matrix
7a6a6d2
@rush-skills
use mongo 4.4 for st2 version > 3.4
0251f3b
@rush-skills
change mongo version 4.4 only for 3.5 not for 3.4
c8154eb
@rush-skills
update mongodb spec with 4.4 as latest version
b230228
@rush-skills
Add ubuntu18 unstable pipeline
b0ad153
@rush-skills
add centos7 unstable build and comment out u20 stable build
0195239
@rush-skills
change tests back to stable repo, remove unstable ci refs
17cd73b
@rush-skills
install mongo 4.4 only on focal
2975b18
@rush-skills
update nodejs version to v14 for st2 >= 3.5
635e4d3
@rush-skills
edit vagrant file to add mongodb 4.4 repo apt key
6fae9a3
@rush-skills
fix mongodb specs
c7adcea
@rush-skills
fix mongodb fact check for u20
6f8de4a
@rush-skills
update mongo version and test for u20
5981f66
@rush-skills
fix brackets
302a094
@rush-skills
try os conditional with if/end
a8ed130
@rush-skills
try if-else for mongodb logic
cb4adb2
@rush-skills
fix typo
abb094c
@rush-skills
fix tests for u20
d9a9b07
This was referenced Sep 14, 2021
Closed
Closed
amanda11
amanda11 requested changes Sep 14, 2021
View reviewed changes
Copy link

@amanda11 amanda11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, it looks really good. That's a huge effort.

I'm not sure whether this ensures redis gets installed now or not, can you confirm that has been added?

I raised a few comments to address, but I'd also like a review by another.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.kitchen.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build/ubuntu20-puppet7/Dockerfile.kitchen Outdated Show resolved Hide resolved
docs/dev_notes.md Show resolved Hide resolved
docs/dev_notes.md Outdated Show resolved Hide resolved
@nmaludy nmaludy self-requested a review September 14, 2021 20:10
@rush-skills
Copy link
Member Author

Thanks so much for this, it looks really good. That's a huge effort.

I raised a few comments to address, but I'd also like a review by another.

Thanks for the review @amanda11 . I have made the changes requested.

I'm not sure whether this ensures redis gets installed now or not, can you confirm that has been added?

Yes this does install Redis as @bishopbm1 added it in #333

nmaludy
nmaludy suggested changes Sep 15, 2021
View reviewed changes
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good!

docs/dev_notes.md Show resolved Hide resolved
manifests/profile/web.pp Show resolved Hide resolved
nmaludy
nmaludy approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you VERY much for these changes. Great work!

@nmaludy nmaludy merged commit a38f961 into StackStorm:master Sep 15, 2021
@arm4b arm4b mentioned this pull request Nov 20, 2021
Merged
@arm4b arm4b mentioned this pull request Apr 4, 2022
Merged
bishopbm1 pushed a commit to EncoreTechnologies/puppet-st2 that referenced this pull request May 20, 2022
@nmaludy
Merge pull request StackStorm#335 from rush-skills/master
7cf1c3f 
Ubuntu 20.04 and refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda11 amanda11 amanda11 requested changes

@nmaludy nmaludy nmaludy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rush-skills @nmaludy @amanda11