Changing to use default ~/.cache/pip instead of wheelhouse with --no-index #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - ST2PKG_RELEASE=${ST2PKG_RELEASE} | ||
| ## For the following variables default values are used | ||
| # unless explicitly defined: | ||
| # - ST2_GITURL= |
There was a problem hiding this comment.
Why commented?
I need all these vars to be passed from CI to Docker environment.
See:
#12
#24 (comment)
There was a problem hiding this comment.
I know. I've commented them because they generate too many unnecessary warnings. At the moment you don't need it, cuz there's no full implementation yet. So far now we leave them commented.
There was a problem hiding this comment.
There are many ways to pass them in, also see docker-compose run --help for -e option. Unless decided what the best approach is, I suggest to leave them commented, since they bloat output with warnings(
|
resolvs #26 |
|
this won't be resolved we stay with wheelhouse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.