[st2client] Updated ActionRunCommand to enable specifying multiple array type value in the action parameter #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple array type value in the action parameter
|
Thanks and nice work! Can you please also open corresponding st2docs PR? |
Kami
approved these changes
Aug 21, 2017
Kami
reviewed
Aug 21, 2017
| 'param_object=hoge=1,fuga=2', | ||
| 'param_boolean=False', | ||
| 'param_array=foo,bar,baz', | ||
| 'param_array_of_dicts=foo:1,bar:2' |
There was a problem hiding this comment.
How does it work if you want to specify multiple objects for an array?
Would something like that work: param_array_of_dicts=foo:1,bar:2,aram_array_of_dicts=foo:3,bar:4.
If yes, let's please add a test case or it and also document it.
Kami
added a commit
that referenced
this pull request
Aug 21, 2017
|
Thank you for your review and merging. It takes time because I've been offline until the end of this week, sorry. |
This was referenced Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change for #3646. The main points of this PR are
transform_arraywhich is the internal method to parse the argument ofarraytype, to be able to parse dict data when user declared that type parameter._get_action_parameters_from_argsto accept multiple declaration of same argument.Thank you.